From: Florian Müllner Date: Tue, 17 Dec 2019 00:00:40 +0000 (+0100) Subject: panel: Disable menu-toggle shortcuts while top bar is hidden X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~781^2^2~290 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=4f66b301e7027f66233914bfa993bedcbbd3abaa;p=gnome-shell.git panel: Disable menu-toggle shortcuts while top bar is hidden We currently handle the case where the indicator itself is disabled (read: hidden), but not when the entire top bar is invisible (for instance when the primary monitor is in fullscreen state). It is odd to pop up a top bar menu without the top bar, so check for the indicator's mapped- instead of visible state. https://gitlab.gnome.org/GNOME/gnome-shell/issues/2002 --- diff --git a/js/ui/panel.js b/js/ui/panel.js index 73002d039..80e6179b6 100644 --- a/js/ui/panel.js +++ b/js/ui/panel.js @@ -962,7 +962,7 @@ class Panel extends St.Widget { } _toggleMenu(indicator) { - if (!indicator || !indicator.container.visible) + if (!indicator || !indicator.mapped) return; // menu not supported by current session mode let menu = indicator.menu;